Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix opening transaction details in Core Lightning #1868

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix opening transaction details in Core Lightning #1868

wants to merge 1 commit into from

Conversation

myxmaster
Copy link
Contributor

Description

This fixes #1862.

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (c-lightning-REST)
  • LndHub
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

kaloudis
kaloudis reviewed Nov 23, 2023
View reviewed changes
models/Transaction.ts
});
return outpoint;
const lastOutputWithOurAddress = this.output_details
?.filter((d) => d.is_our_address)
Copy link
Contributor

@kaloudis kaloudis Nov 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think is_our_address is CLN only so this will break for LND

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, looks like that's an LND property

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured this would have used txid and output from CLN-rest (see https://github.com/Ride-The-Lightning/c-lightning-REST/blob/master/controllers/listfunds.js#L25) if there was going to be a re-write like this

Otherwise, I would have just added some optional chaining (?.) to prevent the crash.

Maybe I'm missing something

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need the is_our_address or an equivalent property for this and listfunds does not provide this. Do you have an idea how to implement this for CLN?

The reason we did not just add a ? is because we think the code is more descriptive now as the last output with is_our_address is used (first we thought the first one would be used).

The question is: Is the last output really the one that should be used? Or maybe rather the one with the biggest amount?

@kaloudis kaloudis mentioned this pull request Nov 27, 2023
Closed
@kaloudis kaloudis marked this pull request as draft December 18, 2023 22:59
@kaloudis kaloudis force-pushed the master branch 6 times, most recently from 1c682d4 to 2068ca3 Compare November 2, 2024 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaloudis kaloudis kaloudis left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App crashes when opening details of an on-chain transaction using Core Lightning
2 participants
@myxmaster @kaloudis